[Spark-20775][SQL] Added scala support from_json#18094
Closed
rubenljanssen wants to merge 3 commits intoapache:masterfrom
Closed
[Spark-20775][SQL] Added scala support from_json#18094rubenljanssen wants to merge 3 commits intoapache:masterfrom
rubenljanssen wants to merge 3 commits intoapache:masterfrom
Conversation
ueshin
reviewed
May 25, 2017
Member
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
LGTM except for minor comments.
cc @cloud-fan @gatorsmile
|
|
||
| /** | ||
| * Parses a column containing a JSON string into a `StructType` or `ArrayType` of `StructType`s | ||
| * (Java-specific) Parses a column containing a JSON string into a `StructType` or `ArrayType` of `StructType`s |
Member
There was a problem hiding this comment.
nit: ScalaStyle check will fail saying File line length exceeds 100 characters.
| } | ||
|
|
||
| /** | ||
| * (Scala-specific) Parses a column containing a JSON string into a `StructType` or `ArrayType` of `StructType`s |
cloud-fan
reviewed
May 25, 2017
| * format is also supported for the schema. | ||
| * | ||
| * @group collection_funcs | ||
| * @since 2.1.0 |
Contributor
|
ok to test |
|
Test build #77379 has finished for PR 18094 at commit
|
|
Test build #77381 has finished for PR 18094 at commit
|
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
from_json function required to take in a java.util.Hashmap. For other functions, a java wrapper is provided which casts a java hashmap to a scala map. Only a java function is provided in this case, forcing scala users to pass in a java.util.Hashmap.
Added the missing wrapper.
How was this patch tested?
Added a unit test for passing in a scala map